-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add runtime-tools' validation tests #1758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
script/oci-runtime-validation
Outdated
| set -e | ||
| set -x | ||
|
|
||
| REPOPATH="$( cd "$(dirname "$0")/.." ; pwd -P )" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems overly complicated. The Makefile calling this script knows where the compiled runc is. Can't we set the RUNTIME enviroment variable in the Makefile rule?
RUNTIME=... script/oci-runtime-validation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, I'll try that.
|
I rebased this PR and this ran the tests on Travis again. The tests show the following errors: Issues in runc:
Limitation of the TravisCI platform
Bug in the certification tests:
To investigate:
|
For now, the results of the tests are printed without returning an error. Signed-off-by: Alban Crequy <[email protected]>
|
I have run the tests again on my laptop: Issues in runc:
|
|
What's current status? |
|
ping |
|
Obsolete patch: the CI significantly changed since 2018. |
For now, the results of the tests are printed without returning an error.
Signed-off-by: Alban Crequy [email protected]
This is superseding #1757: trying to use Travis CI instead of CircleCI.
I see the following in the logs: https://travis-ci.org/kinvolk/runc/jobs/353911723